[Windows] Serial number support for composite USB devices #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serial/tools/list_ports_windows.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| from ctypes.wintypes import ULONG | |||
| from ctypes.wintypes import HKEY | |||
| from ctypes.wintypes import BYTE | |||
| import winerror | |||
There was a problem hiding this comment.
does not seem to be in the standard library
There was a problem hiding this comment.
Thanks for pointing this out - you were correct. This was a module provided by pywin32 that I (incorrectly) thought was part of the standard library on windows. I removed the dependency and added the error as a file-level constant similar to other windows errors handled here.
|
@zsquareplusc Is there anything else you would like to see with this PR? |
|
Thanks for working on this. I think we just hit this issue. I'll be versionning this code and testing it next week. Excited to see this pulled in! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #283 by adding in a device traversal up the USB device tree if a serial number is not detected at the original device node.
This allows composite USB devices to report correct serial numbers on windows.