fix: stop reusing exception instances #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writeTimeoutError and portNotOpenError ware precreated exception instances. When rising these exceptions multiple times, stack trace was appended to existing traces. This leads to two issues - no easy to debug real cause of the exception because of wrong stack trace - memory leak, because stack trace is never cleared. Raising portNotOpenError multiple times (understand e.g. one milion times, for long running script, it is perfectly possible) will cause out of memory this change just assign specially crafted exception classes to existing writeTimeoutError and portNotOpenError variables so they will produce identical message but they are no longer precreated. New exceptions are derived from original SerialTimeoutException and SerialException so existing user code should not break by this change closes: pyserial#437
|
Thanks. I preferred to make instances in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeTimeoutError and portNotOpenError ware precreated exception
instances. When rising these exceptions multiple times, stack trace
was appended to existing traces. This leads to two issues
stack trace
portNotOpenError multiple times (understand e.g. one milion
times, for long running script, it is perfectly possible)
will cause out of memory
this change just assign specially crafted exception classes to
existing writeTimeoutError and portNotOpenError variables so
they will produce identical message but they are no longer
precreated.
New exceptions are derived from original SerialTimeoutException
and SerialException so existing user code should not break by this
change
closes: #437