Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect position of thumbnails #695

Closed
veebch opened this issue Aug 28, 2023 · 5 comments
Closed

Incorrect position of thumbnails #695

veebch opened this issue Aug 28, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@veebch
Copy link

veebch commented Aug 28, 2023

when fzf is restricted to only part of the screen, thumbnails appear outside the border of fzf

To Reproduce

export FZF_DEFAULT_OPTS='--height 40% --layout=reverse --border'
to confine fzf to 40 percent of terminal and then run
ytfzf -t

Expected behavior

Thumbnail appears within the ytfzf window.

Screenshot from 2023-08-28 12-11-23

Screenshots

The thumbnail appears, small, and about 1/3 of the way down the terminal

Information

  • OS: linux
  • Terminal: alacritty
  • Ytfzf version: 2.5
  • Output of readlink $(which sh): bash
  • (if is a thumbnail issue) run ytfzf --thumbnail-log=log.txt and post the file:
    illegal long optionf
@veebch veebch added the bug Something isn't working label Aug 28, 2023
@Euro20179
Copy link
Collaborator

Not sure if this is possible to fix, ytfzf assumes that the preview is at the top of the terminal, and I don't think there's a way to check if it's not at the top of the terminal.

@veebch
Copy link
Author

veebch commented Aug 30, 2023

It's not a huge issue anyway, but seeing as the fzf page suggests setting to 40% as a tweak, it might be worth mentioning in the readme. Brilliant tool though....thankyou!

@veebch veebch closed this as completed Aug 30, 2023
@Euro20179
Copy link
Collaborator

noting in the readme is probably a good idea, ill do that when i can.

@veebch
Copy link
Author

veebch commented Aug 31, 2023

PS If you ever need a video of ytfzf living its best life:

https://www.youtube.com/watch?v=I5iHMEqll0Q :)

@Euro20179
Copy link
Collaborator

I've seen that, it's a really cool project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants