Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LegacySpecifier and LegacyVersion have been dropped in setuptools>=67, causing InvalidVersion #500

Open
maciej-lech opened this issue Aug 23, 2023 · 0 comments · May be fixed by #501
Open

LegacySpecifier and LegacyVersion have been dropped in setuptools>=67, causing InvalidVersion #500

maciej-lech opened this issue Aug 23, 2023 · 0 comments · May be fixed by #501

Comments

@maciej-lech
Copy link

maciej-lech commented Aug 23, 2023 •
edited

Hi!

LegacySpecifier and LegacyVersion have been dropped in setuptools>=67 so util.py:nimbus_storm_version is failing with InvalidVersion because of parse_version("").

I am proposing to return Version('0.0.0') instead of LegacyVersion('') to indicate no Nimbus version has been found.

I can prepare a PR for that. Already forked and used in my project as I couldn't pin setuptools to some old versions.

Best regards,
Maciej Lech
@maciej-lech maciej-lech linked a pull request Aug 23, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix util.py:nimbus_storm_version maciej-lech/streamparse
1 participant
@maciej-lech