[WIP] rename [batch_]psi methods to [batch_]joint_features

[larsmans]

I haven't run the tests yet; this affects the entire codebase and the full test suite is so slow on my box that I'm leaving it to Travis.

What to do with size_psi? Rename it joint_size?

[amueller]

or joint_feature_size. It is used quite rarely I think.
What do the other think about this rename? @vene @fgregg @zaxtax ?

[amueller]

btw @larsmans you can speed up all tests by a factor of ~10 by setting the default inference to ad3 in crf.py (provided you have it installed).

[larsmans]

Haven't tried to install that yet, but I will if I find enough time to play with this stuff longer :)

[amueller]

it should be in a state where you can install it via pip using the repo from the requirements file. if travis can do it, I'm sure you can do it, too ;)

[amueller]

ok, another try pushed to master ;)

[zaxtax]

I'm ok with the rename.

[fgregg]

I don't have a problem with it, but I also don't think it's any clearer.
Could you add some description of what join_features represent in say, the
base.py docstring.

On Thu, Jul 18, 2013 at 8:57 AM, zaxtax notifications@github.com wrote:

I'm ok with the rename.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-21184908
.

773.888.2718
2231 N. Monticello Ave
Chicago, IL 60647

[amueller]

Ok, I agree that this is an improvement after I noticed the different uses if psi in graphical models and structured prediction. For someone reading Bishop, the name \psi is indeed quite confusing.

[amueller]

unfortunately my realization came too late and I I have to deprecate ^^

[larsmans]

Having read some more, I found out that in NLP at least, this is usually called Φ (which I think makes sense since it's a feature function).

[amueller]

Yeah, I will also call it \phi in my thesis now - it is also called that in the Nowozin Lampert book ;)
Though joint_feature is surely a better function name than replacing one greek letter with another.

[amueller]

Done in 354ea19.