Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code coverage above 90% on TopoEmbedX (because of JMLR requirements) #19

Closed
ninamiolane opened this issue Sep 19, 2023 · 5 comments
Closed

Make code coverage above 90% on TopoEmbedX (because of JMLR requirements) #19

ninamiolane opened this issue Sep 19, 2023 · 5 comments
Assignees
@devendragovil @gurug-dev @maneelusf

Comments

@ninamiolane
Copy link
Collaborator

ninamiolane commented Sep 19, 2023 •
edited

What?

JMLR requires that unit-tests' code coverage is "close to 100%". See: https://www.jmlr.org/mloss/mloss-info.html

We can see that, currently, it is at 85%.

Screen Shot 2023-09-19 at 10 22 22 AM

We should make it >90%.

How?

Go to the code coverage page for TopoEmbedX and observe which lines of code are not tested. Write tests for them.
https://app.codecov.io/gh/pyt-team/TopoEmbedX
@ninamiolane
Copy link
Collaborator Author

@devendragovil any chance you could help with this? Thanks in advance.

@mhajij
Copy link
Member

mhajij commented Sep 19, 2023

@maneelusf @gurug-dev

@devendragovil
Copy link
Contributor

Yes I will get working on this @ninamiolane

@devendragovil
Copy link
Contributor

The test coverage has increased to >90% after the recent PR.

@ninamiolane
Copy link
Collaborator Author

Excellent! Thanks @devendragovil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devendragovil devendragovil

@gurug-dev gurug-dev

@maneelusf maneelusf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ninamiolane @devendragovil @mhajij @gurug-dev @maneelusf