Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on scatter utilities #199

Open
ffl096 opened this issue Sep 15, 2023 · 0 comments
Open

Clarification on scatter utilities #199

ffl096 opened this issue Sep 15, 2023 · 0 comments

Comments

@ffl096
Copy link
Member

ffl096 commented Sep 15, 2023

TopoModelX contains some scatter functions in utils.scatter, that -- according to the module docstring -- are adapted from torch_scatter. Is there a specific reason why we ship our own implementation? torch_scatter is a dependency already.

If yes, we should document that reason and how the build-in implementation differs from torch_scatter (which, for me, is not at all obvious from looking at the code). Otherwise remove it and use the existing implementation in torch_scatter everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant