Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please unbundle apipkg #13

Closed
pytestbot opened this issue Jul 21, 2017 · 4 comments
Closed

Please unbundle apipkg #13

pytestbot opened this issue Jul 21, 2017 · 4 comments

Comments

@pytestbot
Copy link

As far as I can see, execnet/apipkg.py in execnet 1.1 is identical to apipkg.py version 1.2. Would it be possible to unbundle it?

Background: Fedora has a policy that forbids bundling of libraries in its packages: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

The related Fedora bug against python-execnet is https://bugzilla.redhat.com/show_bug.cgi?id=790165

@pytestbot
Copy link
Author

Original comment by @hpk42

execnet is meant as a zero-dependency library and it is therefore not currently possible to introduce a dependency, i am afraid. Note that execnet bootstraps itself across host boundaries -- a feature which would break if a dependency were introduced.

@pytestbot
Copy link
Author

Original comment by @tomspur

Would it be possible to accept something like over here:
http://fedoraproject.org/wiki/User:Toshio/Unbundling_Python_Modules
?

So for instance, one could move apipkg.py to _apipkg.py and add a apipkg.py which contains something like:

#!python
try:
    from apipkg import *
except ImportError:
    from _apipkg import *

This would try to import the global library, if available or fall back to the bundled library. When it is packaged in Fedora the bundled library can easily be removed and execnet will still work as expected.

This has worked great, when unbundling all python dependencies of ipython:
ipython/ipython#191

Unfortunately, I cannot directly provide a pull request as my mercurial foo is not as good as my git foo. I will have a look though, if adding changes like the one mentioned above is an option...
Is it? :)

@pytestbot
Copy link
Author

Original comment by @RonnyPfannschmidt

currently it seems like that one is solvable later

@pytestbot
Copy link
Author

Original comment by @thmo

So, looking at the changelog, apipkg got de-bundled in 1.4, right? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants