PendingDeprecationWarning: generator 'pytest_pycollect_makeitem' raised StopIteration

[5j9]

Hi,

I'm getting lots of these warnings when running some of the pywikibot tests using pytest and python 3.5.

WARNING: C:\Users\a\AppData\Local\Programs\Python\Python35\lib\site-packages\_pytest\vendored_packages\pluggy.py:250: PendingDeprecationWarning: generator 'pytest_pycollect_makeitem' raised StopIteration
  wrap_controller.send(call_outcome)

See: https://travis-ci.org/wikimedia/pywikibot-core/jobs/167265098#L493

[goodboy]

@RonnyPfannschmidt @5j9 this is due to PEP 479 which is in full here.

So it's the underlying hookwrapper which is triggering this warning not pluggy code.

In this case the default implementation of pytest_pycollect_makeitem is raising StopIteration (deprecated in py3.6) instead of using return.

However, in order to support py3.6 we need to change _wrapped_call() to except RuntimeErrors alongside StopIterations.
^ Correction it is only the hookwrapper bodies which should change.
A RuntimeError would indicate a raised StopIteration which we should not expect.

@RonnyPfannschmidt I believe and issue with pytest should be made?

[RonnyPfannschmidt]

Correct, thanks for investigation

[goodboy]

@RonnyPfannschmidt pretty sure this can be closed now?

[nicoddemus]

Yep, thanks for the ping!

[nicoddemus]

Fixed in pytest-dev/pytest#2226