New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use scandir package #996
Comments
The same is true for |
Though checking the respective projects, it looks like they are both still updated for newer Python versions, meaning that they are probably still installed (and used) in some installations (given previous experience, in quite a lot). |
I think the |
But, OTOH, the |
Just to clarify: are you using or packaging |
I package pyfakefs for OpenIndiana. I do not have any significant problem with it. I patched out I filed the issue here just to get things improved/cleaned. |
Ah ok, thanks. Edit: I got this wrong. We already import them only if they exist, we just could remove them from the |
Why do you need pyfakefs/pyfakefs/extra_packages.py Line 23 in f7c00de
|
As I wrote, if people still use it, and I would remove it, it would no longer be patched. I realize that nobody actually needs it nowadays, but that does not mean that it is not used (e.g. imported in the code). |
Actually I think I need to sleep over this... Maybe you are right. This is another case than |
This depends. If you just use |
Well, what I basically do is checking if it is installed by trying to import it, and if it is installed, patch it the same way the built-in |
Yes, this would be perfect for me. BTW, I do not need new release with this fixed/changed only. But since you have some regression then you are apparently going to release new version anyway soon... Thank you. |
The simple approach I tried did not work as I wanted it to, so I need a bit more time for this - will have another go probably at the weekend. I decided to go ahead with the patch release to get the fix for the regression out, so this one did not get in, sorry. |
Not a problem at all. Take your time. This is not a high priority issue. |
Version with deprecation is released, usage will be removed in 6.0. Closing. |
The scandir standalone package was needed for Python < 3.5 only. Since
pyfakefs
requires Python >= 3.7 thescandir
should be no longer needed. Unfortunately, there are still some trace ofscandir
in the sources, for example in extra_requirements.txt or in .github/workflows/testsuite.yml.The text was updated successfully, but these errors were encountered: