Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python versions pre-3.5 has been dropped #57

Closed
oberstet opened this issue Jun 6, 2017 · 2 comments
Closed

Support for Python versions pre-3.5 has been dropped #57

oberstet opened this issue Jun 6, 2017 · 2 comments

Comments

@oberstet
Copy link

oberstet commented Jun 6, 2017

This broke our CI (eg here, and we are considering forking pytest-asyncio.

Could s.o. explain why support for Py < 3.5 was dropped? Any particular reason.

@Tinche
Copy link
Member

Tinche commented Jun 6, 2017

The desire to start moving the codebase to async/await exclusively, mostly.

You can continue using 0.5 until you're ready to switch to 3.5+ or drop 3.3/3.4 compatibility (if you're a library). Feel free to fork if it makes sense for you, the license is what it is specifically to allow everyone to do that :)

My opinion is that migrating from 3.4 to 3.5 is very easy (as opposed to migrating from 2.7 to 3+) and if you're doing anything involving asyncio, very very worth it.

@oberstet
Copy link
Author

oberstet commented Jun 6, 2017

@Tinche thanks for explaining! I agree for app code: everyone should move to Python 3.5+.

But we can't do that, as we are maintaining libraries that must run on everything (including Python 2.7 + Trollius):

We'll pin pytest-asyncio at 0.5 for now. I hate forking, and I don't have time now anyways;) I was just hoping that you might reconsider ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants