Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JavaScript test framework to more popular alternative #432

Open
gnikonorov opened this issue Dec 20, 2020 · 1 comment
Open

Migrate JavaScript test framework to more popular alternative #432

gnikonorov opened this issue Dec 20, 2020 · 1 comment
Labels
code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) next-gen Candidate for the next-gen project test This PR relates to tests, QA, CI.

Comments

@gnikonorov
Copy link
Member

gnikonorov commented Dec 20, 2020

We currently use QUnit for unit testing our JavaScript.

I propose that we move to a more modern testing framework ( the top five listed here seem to pop up a bit ).

I would like to add that any library we migrate to should have good support for testing URL parameters. QUnit forces the definition of one test script per URL which I think isn't ideal, since it's pretty cumbersome: https://stackoverflow.com/questions/27388596/pass-url-parameter-to-qunit-test-using-grunt

As a follow up, tests should be written for all URL parameters, since we currently have 0 tests for them.

@BeyondEvil maybe this is something we could tackle as part of the next gen migration?

@gnikonorov gnikonorov added test This PR relates to tests, QA, CI. code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) labels Dec 20, 2020
@BeyondEvil
Copy link
Contributor

@BeyondEvil maybe this is something we could tackle as part of the next gen migration?

Yes!

@BeyondEvil BeyondEvil added the next-gen Candidate for the next-gen project label Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) next-gen Candidate for the next-gen project test This PR relates to tests, QA, CI.
Projects
None yet
Development

No branches or pull requests

2 participants