Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'args' attribute to SignalBlocker. #115

Merged
merged 2 commits into from Dec 16, 2015
Merged

Add an 'args' attribute to SignalBlocker. #115

merged 2 commits into from Dec 16, 2015

Conversation

The-Compiler
Copy link
Member

Closes #64.

Maybe #114 needs a look first though - if there's anything wrong in the logic in _quit_loop_by_signal we'll just get a hang otherwise.

I have only tested on PyQt5.

@The-Compiler
Copy link
Member Author

I have only tested on PyQt5

Seems like that means it only works on PyQt5 😆

Looks like PyQt4/PySide both don't have QSignalSpy available? I'll have to check how hard it'd be to do our own implementation of something similar instead.

@The-Compiler
Copy link
Member Author

Hah, looks like that's a lot easier and works everywhere.

@nicoddemus
Copy link
Member

Excellent, many thanks @The-Compiler! 😄

I'm thinking of releasing 1.10 right away with this, what do you think?

nicoddemus added a commit that referenced this pull request Dec 16, 2015
Add an 'args' attribute to SignalBlocker.
@nicoddemus nicoddemus merged commit 5c9fc59 into pytest-dev:master Dec 16, 2015
@The-Compiler
Copy link
Member Author

After the adjustment from #114, sure, why not? I don't think I have anything I want to contribute in the next hours/days. I still need to look at #63 again. 😆

nicoddemus added a commit that referenced this pull request Dec 16, 2015
@nicoddemus
Copy link
Member

I don't think I have anything I want to contribute in the next hours/days.

Yeah, me too... pretty busy this week I'm afraid.

I still need to look at #63 again.

So do I. 😞

@The-Compiler
Copy link
Member Author

No worries! The most annoying issue for me currently is #113, but I understand you're busy, and I have no idea how to tackle that one myself... 😉

@nicoddemus
Copy link
Member

1.10.0 is out. 😄

@The-Compiler
Copy link
Member Author

Nice, thank you!

@The-Compiler The-Compiler deleted the signal-args branch December 16, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants