Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

no copyright/license included with source #16

Closed
brianmay opened this issue Apr 3, 2016 · 4 comments
Closed

no copyright/license included with source #16

brianmay opened this issue Apr 3, 2016 · 4 comments

Comments

@brianmay
Copy link

brianmay commented Apr 3, 2016

Apparently it is MIT licensed, there is nothing I can see with the source to confirm this. Such as a copy of the MIT license for example.

@jaraco
Copy link
Contributor

jaraco commented Apr 3, 2016

It is MIT Licensed, which is declared in the source and further reflected and searchable by license in the metadata. I choose not to create a copy of the license with the source as I feel a reference to a common license is adequate.

@jaraco jaraco closed this as completed Apr 3, 2016
@flub
Copy link
Member

flub commented Apr 3, 2016

Erm, we do actually ask for all projects under pytest-dev to include a LICENSE or LICENSE.txt file in the toplevel (https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev). Apologies for missing this earlier but it would be really appreciated if you could add this anyway.

Thanks,
Floris

@flub flub reopened this Apr 3, 2016
@jaraco
Copy link
Contributor

jaraco commented Apr 4, 2016

Those docs are specifically about plugins, so it's arguable that those guidelines don't apply to this repo, which violates other provisions there (uses README.rst instead of README.txt and doesn't have a tox.ini). Given the preference by pytest-dev, I'll reluctantly accept a PR to correct the issue, but I won't be spending any time on it myself.

@jaraco jaraco closed this as completed Apr 4, 2016
@flub
Copy link
Member

flub commented Apr 11, 2016

Sure this is no plugin, but I don't think that makes it exempt from the pytest-dev guidelines. And a README by whatever extension is fine. Anyway, I've created a PR now: #17

As for a tox.ini, this surely is more work but it would still be good to add. It seems currently there's no automated tests at all which is something we where trying to avoid in pytest-dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants