Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dropped support to old pytest versions #321

Merged
merged 6 commits into from
Jul 28, 2018
Merged

Revert dropped support to old pytest versions #321

merged 6 commits into from
Jul 28, 2018

Conversation

nicoddemus
Copy link
Member

This release reverts the change that dropped support for older pytest versions. We should consider this change only for 1.23.

Issues:

pytest-dev/pytest#3724
#319

@nicoddemus
Copy link
Member Author

Oh of course. It was because of six.

So to fix this we would need to either revert six usage, or include six as a dependency. The first is not good because it will generate more work for us (remove and include it back in a future release), the second will likely cause problems as well.

What do you suggest @RonnyPfannschmidt?

@nicoddemus
Copy link
Member Author

I'm leaning towards just live with this; it doesn't seem to be our fault after all, and will likely be a problem only in the short term (I think).

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Jul 28, 2018
View reviewed changes
CHANGELOG.rst
pytest-xdist 1.22.5 (2018-07-27)
================================

Bug Fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seems to be a B missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest to do a minor release adding six

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

About the missing B, it is some bug on GH's diff, the file is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing B is a problem with "Refined GitHub": refined-github/refined-github#1444

@nicoddemus nicoddemus merged commit 96af694 into pytest-dev:master Jul 28, 2018
@nicoddemus nicoddemus deleted the release-1.22.5 branch July 28, 2018 12:50
@bmw bmw mentioned this pull request Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicoddemus @RonnyPfannschmidt