New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test loss function signatures #50
Comments
originally posted by Anton Akhmerov (@anton-akhmerov) at 2018-11-21T20:54:13.437Z on GitLab Also we probably shouldn't be naming factory functions for loss functions |
originally posted by Bas Nijholt (@basnijholt) at 2018-12-07T19:21:26.066Z on GitLab @anton-akhmerov I think we addressed these points (except the second one) recently. I don't really understand what you mean with
Should we just check the data type? Is that what you mean? If so, why would this be useful? |
originally posted by Anton Akhmerov (@anton-akhmerov) at 2018-12-07T20:31:19.691Z on GitLab
I cannot confirm that learners clearly document the loss format.
Did I miss any learner with customizable loss? |
originally posted by Anton Akhmerov (@anton-akhmerov) at 2018-12-07T20:32:56.682Z on GitLab
I think that makes sense for the purpose of API stability. |
(original issue on GitLab)
opened by Anton Akhmerov (@anton-akhmerov) at 2018-07-23T19:06:55.212Z
A loss function is a significant part of the interface of each learner. It provides the users with nearly infinite ways to customize the learner's behavior, and it is also the main way for the users to do so.
As a consequence I believe we need to do the following:
Learner2D
passes an interpolation instance to the loss, we should try and runLearner2D
with the loss that verifies that its input is indeed an instance of interpolation. We did not realize this, butloss
is a part of the learner's public API.learner2D.resolution_loss(ip, min_distance=0, max_distance=1)
does not conform to the spec, and is not directly reusable. Instead this should have been afunctools.partial(learner2D.resolution_loss, min_distance=0, max_distance=1)
.The text was updated successfully, but these errors were encountered: