Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slotted cached property reference #1221

Merged

Conversation

diabolo-dan
Copy link
Contributor

@diabolo-dan diabolo-dan commented Jan 3, 2024

Summary

Address problems raised in #1220 around cached_propertys in slotted classes:

  • class reference remaining causing original class to not be gc'd.
  • cached_property functions with class closures not getting updated.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    Our CI fails if coverage is not 100%.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
      If the next version is the first in the new year, it'll be 23.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@Tinche Tinche linked an issue Jan 3, 2024 that may be closed by this pull request
@hynek
Copy link
Member

hynek commented Jan 4, 2024

@AdrianSosic can you confirm this is fixing it for you?

@AdrianSosic
Copy link

@AdrianSosic can you confirm this is fixing it for you?

Yes, this indeed fixes the issues. Is there any chance we can get this as a 23.2.1? Or when do you see this being released?

@hynek hynek added this pull request to the merge queue Jan 4, 2024
Merged via the queue into python-attrs:main with commit 26d8dd7 Jan 4, 2024
20 checks passed
@hynek
Copy link
Member

hynek commented Jan 4, 2024

Is there any chance we can get this as a 23.2.1? Or when do you see this being released?

I’ll do a 24.1 soon-ish – I’ll just wait a moment if other regressions pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using cached_property results in undesired references
4 participants