Recursively evolve nested attrs classes #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynek
requested changes
Feb 18, 2021
Co-authored-by: Hynek Schlawack <hs@ox.cx>
|
Applied your suggestions and updated the test to include a change to |
|
Thanks! |
| changes[init_name] = value | ||
| elif has(value): | ||
| # Evolve nested attrs classes | ||
| changes[init_name] = evolve(value, **changes[init_name]) |
There was a problem hiding this comment.
doesn't that break the edge case of legitimately replacing a attrs instance with a dict where permissible?
There was a problem hiding this comment.
has(value) makes sure we only attempt recursion when the current value is an attrs class.
I added a test asserting that dicts can still normaly be replaced, nonetheless. :)
sscherfke
added a commit
that referenced
this pull request
Feb 19, 2021
hynek
added a commit
that referenced
this pull request
May 6, 2021
hynek
added a commit
that referenced
this pull request
May 6, 2021
* Revert "Recursively evolve nested attrs classes (#759)" * Add regression test * lol legacy python * Add newsfragment * Add a test to prevent inst -> dict replacement breaking
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #634
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do. If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives. Find the appropriate next version in our__init__.pyfile..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!