Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on setuptools since Python 3.12 #1033

Merged
merged 1 commit into from Oct 23, 2023
Merged

Depend on setuptools since Python 3.12 #1033

merged 1 commit into from Oct 23, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Oct 7, 2023

The dependency was already added specifically for CI, but that is not correct, because it's the package itself that actually depends on setuptools

@oprypin
Depend on setuptools since Python 3.12
08c199b 
The dependency was already added specifically for CI, but that is not correct, because it's the package itself that actually depends on setuptools
@oprypin oprypin mentioned this pull request Oct 7, 2023
Closed
vstinner
vstinner approved these changes Oct 7, 2023
View reviewed changes
Copy link

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You might explain in a comment that the intent of installing setuptools is to get distutils ;-)

akx
akx approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@akx akx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I only wish I knew how many people still depend on the distutils/setuptools stuff in the first place.

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited

Codecov Report

Merging #1033 (08c199b) into master (76677ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1033   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files          25       25           
  Lines        4393     4393           
=======================================
  Hits         3997     3997           
  Misses        396      396

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx merged commit eeb2feb into python-babel:master Oct 23, 2023
26 checks passed
@oprypin oprypin deleted the setup312 branch October 23, 2023 19:48
@almet almet mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distutils no longer part of Python 3.12 - error due to missing dependency
3 participants
@oprypin @akx @vstinner