Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple pybabel frontend from distutils/setuptools; remove dependency #1041

Merged
merged 3 commits into from Nov 22, 2023

Conversation

akx
Copy link
Member

@akx akx commented Oct 30, 2023

Fixes #1040

@akx akx force-pushed the de-setuptools branch 4 times, most recently from 80d25a8 to 29be91d Compare October 31, 2023 12:16
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (65de3dc) 89.82% compared to head (25467f9) 91.34%.
Report is 1 commits behind head on master.

Files Patch % Lines
babel/messages/setuptools_frontend.py 60.00% 8 Missing ⚠️
babel/messages/frontend.py 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   89.82%   91.34%   +1.52%     
==========================================
  Files          25       26       +1     
  Lines        4391     4415      +24     
==========================================
+ Hits         3944     4033      +89     
+ Misses        447      382      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review October 31, 2023 12:48
@akx
Copy link
Member Author

akx commented Oct 31, 2023

Cc @sigma67 @oprypin if you want to take a review-y look! :)

Copy link

@sigma67 sigma67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast response. Seems it will be a breaking change for those using the setuptools integration?

setup.py Show resolved Hide resolved
@akx
Copy link
Member Author

akx commented Nov 21, 2023

@oprypin Could you review this too? :)

@oprypin
Copy link
Contributor

oprypin commented Nov 21, 2023

@akx OK hopefully I'll get to it today. If I don't, then let's skip my review

Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!
I have only one big comment about the legacy re-exports

babel/messages/frontend.py Outdated Show resolved Hide resolved
@oprypin
Copy link
Contributor

oprypin commented Nov 21, 2023

Also checked that MkDocs' setup.py integration (before it was removed) works with this change (also with my suggested edit)

Co-authored-by: Oleh Prypin <oleh@pryp.in>
@akx akx merged commit bf7b2ca into master Nov 22, 2023
25 of 26 checks passed
@akx akx deleted the de-setuptools branch November 22, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make setuptools an optional dependency?
3 participants