Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractPythonTestCase.test_extract_strip_comment_tags fails on PyPy3 7.3.4 (+ sec backports) #784

Closed
mgorny opened this issue Apr 29, 2021 · 3 comments
Assignees

Comments

@mgorny
Copy link
Contributor

mgorny commented Apr 29, 2021

_____________________________________________ ExtractPythonTestCase.test_extract_strip_comment_tags ______________________________________________

self = <tests.messages.test_extract.ExtractPythonTestCase testMethod=test_extract_strip_comment_tags>

        def test_extract_strip_comment_tags(self):
            buf = BytesIO(b"""\
    #: This is a comment with a very simple
    #: prefix specified
    _('Servus')
    
    # NOTE: This is a multiline comment with
    # a prefix too
    _('Babatschi')""")
            messages = list(extract.extract('python', buf, comment_tags=['NOTE:', ':'],
                                            strip_comment_tags=True))
            self.assertEqual(u'Servus', messages[0][1])
            self.assertEqual([u'This is a comment with a very simple',
>                             u'prefix specified'], messages[0][2])
E                             AssertionError: Lists differ: ['This is a comment with a very simple', 'prefix specified'] != []
E                             
E                             First list contains 2 additional elements.
E                             First extra element 0:
E                             'This is a comment with a very simple'
E                             
E                             - ['This is a comment with a very simple', 'prefix specified']
E                             + []

tests/messages/test_extract.py:422: AssertionError
$ pypy3 --version
Python 3.7.10 (51efa818fd9b24f625078c65e8e2f6a5ac24d572, Apr 09 2021, 09:35:49)
[PyPy 7.3.4 with GCC 10.3.0]

Reproduced using git master @ 7ebdf5a via tox -e pypy3.

@akx
Copy link
Member

akx commented Apr 8, 2022

Hi @mgorny, thanks for the report!

I just bumped the version of Pypy used in the tests and this doesn't seem to be happening anymore: https://github.com/python-babel/babel/runs/5885180167?

Successfully setup PyPy 7.3.9 with Python (3.7.13)
[...]
platform linux -- Python 3.7.13[pypy-7.3.9-final], pytest-7.1.1, pluggy-1.0.0
[...]
3156 passed, 1 skipped, 46 warnings in 205.24s (0:03:25)

Can you check against the current master?

@mgorny
Copy link
Contributor Author

mgorny commented Apr 8, 2022

I've just tested it against PyPy3.9 7.3.9 and all tests pass for me.

@akx
Copy link
Member

akx commented Apr 8, 2022

Good to hear!

@akx akx closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants