Domains, caching, etc. #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrjoes
commented
Apr 11, 2012
mrjoes
commented
- Implemented localization domain support
- If babel is not initialized, gettext/format_date/etc won't crash
- Localization caching - won't reload translations for each and every request
- Updated tests
- Updated docs
…ants to use gettext.
…-Babel was not initialized.
… data, as it is being cached by pytz.
|
The problem I see with this is that there is cached stuff stored in the default domain. That one however gets the translations from potentially different flask applications. The cache really has to be per application for this to work. |
|
Whoops, correct. Fixing it. |
|
Related question - can one Flask application have more than one Babel instance? I doubt it can, as localizations lookup app.extensions['babel'] and only latest instance of the Babel class will be used. So, I assume translations for default domain can be cached in the Babel instance. |
|
Want this feature to translate flask-admin |
|
+1 |
babel is initialized for that app. * Make it possible to change the default domain used within a request.
|
+1 |
Allow init_app to be called after package load.
Fix issue about Python 3 support
* Fixes a problem with lazy_gettext and lazy_pgettext evaluating the domain immediately instead of lazily evaluating the domain, causing e.g problem when you set a default domain.
Fix lazy gettext problem with domain evaluation
|
Unfortunately based off of your master branch, making the PR overbroad and unusable. Would gladly merge a PR that implemented caching off the current codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.