New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signal to force beaver to reconnect to redis #75
Comments
Should be a general HUP signal, which the transports can ignore or do something about. |
Well I just thought about it, and I have the following thoughts:
Not that I am opposed completely to this issue, but I think it should be handled adequately already, no? |
On Mon, Dec 17, 2012 at 07:00:34PM -0800, Jose Diaz-Gonzalez wrote:
it does, and it works fine. The only time there's an issue is when it
beaver doesn't currently remember where it left off in the log file. If
The main reason I'm looking for something like this is because if I take With beaver remembering where it left off this becomes a non-issue, just -Jeremy |
See the open milestone. This will get taken care of extremely soon ;) |
Does it stop trying to reconnect for redis? Again, a TransportException is the way to go, because it will eventually try and reconnect. Redis does not currently throw this exception, but it should somewhat ameliorate the issue. If you still think this is a noteworthy feature - seems neat - I am not opposed to seeing a PR for it :). Whenever my redis changes, I just send a restart command to |
Should it reparse the config file on |
On Tue, Dec 18, 2012 at 12:42:40AM -0800, Jose Diaz-Gonzalez wrote:
that would be cool but not necessary for this particular issue. I think restarting would be a simpler solution (code-wise, etc) once -Jeremy |
Well there you go, we should do signal handling still then. I have a firm grasp of how it works too! |
Closing due to inactivity. Happy to see a PR for the signal handling if anyone still has that requirement... |
In my setup I'm thinking about having a number of redis instances behind a load balancer. This is for ease of maintenance and redundancy and such.
However, since beaver's redis connections are sticky, should I take one of them down and put it back in service, it will never get any more connections.
I think being able to send a HUP or something to beaver to make it reconnect to redis would be a great option. This would allow me to then tell my beavers to reconnect and the load balancer should take care of spreading things back out again.
The text was updated successfully, but these errors were encountered: