Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build on python 3.12 #129

Closed
veenstrajelmer opened this issue Dec 8, 2023 · 5 comments
Closed

Does not build on python 3.12 #129

veenstrajelmer opened this issue Dec 8, 2023 · 5 comments
Labels

Comments

@veenstrajelmer
Copy link

cachier cannot be installed on Python 3.12 because of a pathtools dependency, which in turn depends on imp. The pathtools issue is https://github.com/gorakhargosh/pathtools.

pathtools is not imported in cachier, but it is stated as a requirement in the pyproject.toml:

cachier/setup.py

Lines 53 to 57 in f1a96b8

install_requires=[
'watchdog', 'portalocker',
'pathtools', # for watchdog, who has dependency spec problem
'setuptools>=67.6.0', # to avoid vulnerability in 56.0.0
],

It states that it is for watchdog, but if I look in that repos pathtools does not seem to be a requirement there.

Could this requirement not be removed so cachier is installable on Python 3.12?

@shaypal5
Copy link
Collaborator

I removed the pathtools dependency and things seem to work, by Python 3.12 testing doesn't work because of a pip issue. See here:
https://github.com/python-cachier/cachier/actions/runs/7186576860

@shaypal5 shaypal5 added the bug label Dec 12, 2023
@veenstrajelmer
Copy link
Author

veenstrajelmer commented Dec 12, 2023

The action run you are pointing to states "this is likely not a problem with pip", so could it be that it is not a pip issue? If I scroll up a bit I see see "AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?". This comes not from the cachier sourcecode, but the versioneer script. Reading in the configparser documentation it seems that they have deprecated SafeConfigParser in favor of Configparser. It does not explain why this only occurs on py312 though, but maybe you could try replacing this? They still support python>=3.8, so I guess replacing it should work for all testbanks.

@shaypal5
Copy link
Collaborator

Oh snap! I misread that!

OK. So it does look like it's a versioneer issue!
I'm going to try to solution applied here:
https://github.com/Matoking/python-ed25519-blake2b/pull/3/files

@shaypal5 shaypal5 reopened this Dec 13, 2023
@shaypal5
Copy link
Collaborator

shaypal5 commented Dec 13, 2023

Done. Released in v2.2.2.

@veenstrajelmer
Copy link
Author

Thanks a lot for these quick actions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants