version 0.8.3 dependency handling breaks cliff

[dhellmann]

I had a bug report against cliff that cmd2 0.8.3 breaks the interactive mode because of a missing package. Looking at setup.py, I see it doing a bunch of logic in Python that could be handled using environment markers passed to setuptools instead that would let it be more reliable and let it work with wheels.

The original bug report is at https://bugs.launchpad.net/python-cliff/+bug/1762715

[tleonhardt]

@dhellmann
Hi Doug,

We apologize for breaking cliff. Thanks for creating the issue.

PR #330 was created by @nsoranzo to add "wheel-compatible conditional requirements" which should now allow us to work with wheels as well as source distributions.

I am relatively ignorant when it comes to setuptools. I just published a wheel of the 0.8.3 release to PyPI. But it appears to be specific to Python 3.6. Could you perhaps explain how we can publish a more generic wheel to PyPI?

Thanks,

Todd

[tleonhardt]

Oh and for whatever it is worth, the new dependency that was added for POSIX (non-Windows) platforms is wcwidth.

[nsoranzo]

The issue was introduced in commit 2f4198e where the new wcwidth requirement was added only for setuptools < 18 . I'll open a PR to fix this and allow generic wheels (if possible).

[tleonhardt]

@nsoranzo
Thanks Nicola!

I see what you are talking about, the new wcwitdh wasn't added to the happy-day path of setup.py for newer versions of setuptools.

If your PR could allow generic wheels that would be awesome.

[tleonhardt]

We will have to try releasing a new Wheel distribution to PyPI and see how it goes.

@dhellmann Do you think that the changes @nsoranzo made in PR #347 should address the problems the recent release of cmd2 created for cliff?

[tleonhardt]

A new 0.8.4 release was created which should hopefully fix the deficiencies with 0.8.3. If there are still problems, we can re-open this issue.

[dhellmann]

Wow, I go offline for an hour or two and you've got a fix in place and released. My cursory test with 0.8.4 does seem to indicate that everything is fine now. Thanks!