Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke tag command has issues #579

Closed
tleonhardt opened this issue Oct 13, 2018 · 1 comment · Fixed by #581
Closed

invoke tag command has issues #579

tleonhardt opened this issue Oct 13, 2018 · 1 comment · Fixed by #581

Comments

@tleonhardt
Copy link
Member

tleonhardt commented Oct 13, 2018

The “invoke tag” command for adding a Git tag didn’t work properly when doing the 0.9.5 and 0.9.6 releases. This issue only affects cmd2 releases and is completely irrelevant to users of cmd2.

@tleonhardt
Copy link
Member Author

The "invoke tag" command was working, but name was an optional argument which meant that it needed to be passed using a flag like so:

invoke tag -n tag_name

However, the Contributor's Guide stated like it should be used in the more intuitive fashion:

invoke tag tag_name

I will convert name to be a required argument so that it functions in the more intuitive fashion called out by the Contributor's Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant