Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dB as default for Bode plot? #46

Closed
murrayrm opened this issue Feb 7, 2015 · 2 comments
Closed

Use dB as default for Bode plot? #46

murrayrm opened this issue Feb 7, 2015 · 2 comments

Comments

@murrayrm
Copy link
Member

murrayrm commented Feb 7, 2015

Roberto Bucher suggests:

"bode" and "bode_plot": in my opinion the flag dB=True should be the
default choice (but this is only my opinion...)

@murrayrm
Copy link
Member Author

murrayrm commented Feb 7, 2015

This is obviously a matter of choice, but I agree that dB is the most commonly used convention. Karl Astrom and I chose not to use dB in our book since it often wasn't part of a students vocabulary in areas outside of electrical engineering (eg, biology or economics). The function use_matlab_defaults will set the default to use dB for Bode plots, if that helps.

There is stub code (currently commented out) in control/matlab.py that will call use_matlab_defaults and so using the matlab module would give plots compatible with matlab.

@murrayrm
Copy link
Member Author

This has been fixed as of commit ebf8364 as part of PR #62. If you are using the MATLAB subpackage, the default units for Bode plots are in dB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant