Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control.forced_response argument T #586

Closed
forgi86 opened this issue Mar 24, 2021 · 1 comment · Fixed by #588
Closed

control.forced_response argument T #586

forgi86 opened this issue Mar 24, 2021 · 1 comment · Fixed by #588
Assignees

Comments

@forgi86
Copy link
Contributor

forgi86 commented Mar 24, 2021

In version 0.9:

  • For a discrete-time system , the time vector should be optional in the forced response (as stated in the documentation).
    However, this code does not work for me:

sys = control.drss(states=1, outputs=1, inputs=1)
u = np.random.randn(1000)
control.forced_response(sys, U=u)

  • Also, the default value of return_x is stated to be True in the docstring, but it is None (False?) in the code.
@bnavigator
Copy link
Contributor

bnavigator commented Mar 24, 2021

  • For a discrete-time system , the time vector should be optional in the forced response (as stated in the documentation).

Automatic timevector calculation only works if the sys has dt specified. Should be stated more explicitly in the documentation and a better error message should be provided.

Plus, there is a bug in drss. It should return a system with dt=True, but the returned system has dt=0.

  • Also, the default value of return_x is stated to be True in the docstring, but it is None (False?) in the code.

Agreed, this is a bug an error in the documentation. Since 0.9.0 the default value of config.defaults['forced_response.return_x'] is False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants