Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django API Support: Defcon cog #116

Closed
pydis-bot opened this issue Nov 17, 2018 · 13 comments
Closed

Django API Support: Defcon cog #116

pydis-bot opened this issue Nov 17, 2018 · 13 comments
Labels
a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) good first issue Good for newcomers

Comments

@pydis-bot
Copy link

Originally posted by Johannes Christ:

Add support for using the Defcon cog with the new Django API. The branch should be branched off https://gitlab.com/python-discord/projects/bot/merge_requests/67 and the merge request should head back into the linked branch.

This is a good first issue - if you have any questions about this or want more information, don't hesitate to ask!

@pydis-bot pydis-bot added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) Cogs good first issue Good for newcomers labels Nov 17, 2018
@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #87

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #78

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #86

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #85

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #84

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #83

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #82

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #81

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

marked this issue as related to #80

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

We need to think about a smart way to store this kind of things in the bot. Maybe we should have a bot_settings table on the site? The issue would probably be types, as we would have to use a unified format for all settings. Alternatively, we could use a format

CREATE TABLE bot_settings (
    category    VARCHAR(20),
    settings    JSONB
);

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

The issue with that approach would be that we wouldn't be able to properly validate settings unless we would hardcode the per-category setting format.

@pydis-bot
Copy link
Author

Comment from Johannes Christ:

... which might not be a horrible idea.

@MarkKoz
Copy link
Member

MarkKoz commented Aug 6, 2019

This was implemented in 2469592

@MarkKoz MarkKoz closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants