Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of .quiz help #1502

Closed
1 of 2 tasks
n0Oo0Oo0b opened this issue Apr 2, 2024 · 4 comments · Fixed by #1500
Closed
1 of 2 tasks

Improve formatting of .quiz help #1502

n0Oo0Oo0b opened this issue Apr 2, 2024 · 4 comments · Fixed by #1500
Labels
good first issue Good for newcomers status: approved The issue has received a core developer's approval type: bug Something isn't working

Comments

@n0Oo0Oo0b
Copy link

In the embed for .quiz help, the spacing between categories is smaller than the spacing between each category name and description:

image

It would make more sense to put the category name and description closer together, which may come in the form of changing the display format entirely.

Relevant code is here:

def category_embed(self) -> discord.Embed:

Additional info

I suspect this is a side effect of Discord supporting markdown (since we're only adding single newlines in the embed), so only adjusting the spacing may be impossible.

Would you like to implement a fix?

Note: For high-priority or critical bugs, fixes may be implemented by staff.

  • I'd like to implement the bug fix
  • Anyone can implement the bug fix
@n0Oo0Oo0b n0Oo0Oo0b added the type: bug Something isn't working label Apr 2, 2024
@wookie184
Copy link
Contributor

Agreed, it is pretty ugly currently. We could even put the category name on the same line as the description.

Whoever wants to PR can play around and see what looks good.

@wookie184 wookie184 added status: approved The issue has received a core developer's approval good first issue Good for newcomers labels Apr 2, 2024
@hedyhli
Copy link
Member

hedyhli commented Apr 2, 2024

Hello @n0Oo0Oo0b I noticed this today too, I've opened a PR at #1500 earlier today 😄

@hedyhli hedyhli linked a pull request Apr 2, 2024 that will close this issue
@n0Oo0Oo0b
Copy link
Author

Hello @n0Oo0Oo0b I noticed this today too, I've opened a PR at #1500 earlier today 😄

My bad, I only checked issues for duplicates. I'll make sure to check PRs as well in the future 👍

@hedyhli
Copy link
Member

hedyhli commented Apr 4, 2024

No worries, it's good to have an issue to link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status: approved The issue has received a core developer's approval type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants