Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8-test fails because of bare except #267

Closed
1 task done
patkan opened this issue Oct 24, 2017 · 1 comment
Closed
1 task done

flake8-test fails because of bare except #267

patkan opened this issue Oct 24, 2017 · 1 comment
Labels
easy hacktoberfest

Comments

@patkan
Copy link
Member

patkan commented Oct 24, 2017

I have:

  • searched open and closed issues for duplicates

Bug description

The flake8-test fails because line 700 in escpos.py uses a bare except. This should be fixed by catching only the relevant exception with exept. (You have to try first, which exception exactly occurs).
@belono belono mentioned this issue Oct 24, 2017
Merged
3 tasks
@patkan
Copy link
Member Author

patkan commented Dec 3, 2017

fixed with #268

@patkan patkan closed this as completed Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patkan