This repository has been archived by the owner on May 4, 2020. It is now read-only.
Allows get sheet or sheet index by sheet name #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjw296
suggested changes
Oct 6, 2016
| try: | ||
| self.wb.get_sheet(1.1) | ||
| except Exception as e: | ||
| self.assertTrue('sheet must be integer or string', e) |
There was a problem hiding this comment.
This isn't asserting what you think it's asserting...
(hint: put e=None on the line above...)
There was a problem hiding this comment.
Sorry, I did not understand what you mean by putting e=None. Why do you think is not asserting?
There was a problem hiding this comment.
Then please go and read the documentation for assertTrue so you understand why it's the wrogn assertion method to use here. Hint: your current assertion will always pass. When you write tests, make sure they fail before fixing the code...
There was a problem hiding this comment.
You where rigth, my mistake :). I was trying to test the exception message. I'll test only if the exception is raised then.
sjmachin
suggested changes
Oct 10, 2016
|
Fixed on last commit. |
sjmachin
approved these changes
Oct 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request is referent to #66, that was closed due lack of feedback. I've made the changes that you requested. Sorry, but I was working in another project.