Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move the request call to the backend #2413

Merged
merged 1 commit into from Dec 10, 2022
Merged

refactor: move the request call to the backend #2413

merged 1 commit into from Dec 10, 2022

Conversation

lmilbaum
Copy link
Collaborator

@lmilbaum lmilbaum commented Dec 6, 2022

No description provided.

@lmilbaum lmilbaum force-pushed the http_request branch 10 times, most recently from ce8e6b7 to bff0116 Compare December 7, 2022 03:47
@lmilbaum lmilbaum marked this pull request as ready for review December 7, 2022 04:04
nejch
nejch requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmilbaum, just a few initial questions on the typing here.

gitlab/http_backends/requests_backend.py Outdated Show resolved Hide resolved
gitlab/http_backends/requests_backend.py Show resolved Hide resolved
@lmilbaum lmilbaum requested review from nejch and removed request for nejch December 10, 2022 12:16
@lmilbaum lmilbaum requested a review from nejch December 10, 2022 12:56
@nejch nejch enabled auto-merge (squash) December 10, 2022 13:02
@nejch nejch changed the title refactor: Moving the request call to the backend refactor: move the request call to the backend Dec 10, 2022
@nejch nejch merged commit 283e7cc into python-gitlab:main Dec 10, 2022
@lmilbaum lmilbaum deleted the http_request branch December 10, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmilbaum @nejch