Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Response object to backends #2420

Merged
merged 1 commit into from Dec 19, 2022

Conversation

lmilbaum
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Merging #2420 (62e535b) into main (c7cf0d1) will increase coverage by 0.00%.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          84       84           
  Lines        5534     5542    +8     
=======================================
+ Hits         5320     5328    +8     
  Misses        214      214           
Flag Coverage Δ
api_func_v4 82.60% <90.47%> (+0.02%) ⬆️
cli_func_v4 82.91% <80.95%> (+0.02%) ⬆️
unit 87.45% <90.47%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/client.py 98.55% <90.90%> (ø)
gitlab/http_backends/__init__.py 100.00% <100.00%> (ø)
gitlab/http_backends/requests_backend.py 100.00% <100.00%> (ø)

@lmilbaum lmilbaum changed the title Response refactor: RequestsResponse Dec 10, 2022
@lmilbaum lmilbaum marked this pull request as ready for review December 10, 2022 14:01
@lmilbaum lmilbaum force-pushed the response branch 2 times, most recently from 459af58 to 62e535b Compare December 11, 2022 11:01
gitlab/client.py Outdated Show resolved Hide resolved
@lmilbaum
Copy link
Collaborator Author

@nejch Kindest reminder

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @lmilbaum, I've looked at this a few times now and looks ok to me, I'm just not 100% sure how we're going to split this later for streaming responses. Let's try this, just one more question.

gitlab/http_backends/requests_backend.py Outdated Show resolved Hide resolved
gitlab/client.py Outdated Show resolved Hide resolved
@nejch nejch changed the title refactor: RequestsResponse refactor: move Response object to backends Dec 18, 2022
@lmilbaum lmilbaum force-pushed the response branch 5 times, most recently from 1c0e1d6 to ece6576 Compare December 18, 2022 20:50
@nejch nejch merged commit 7d9ce0d into python-gitlab:main Dec 19, 2022
@lmilbaum lmilbaum deleted the response branch December 19, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants