Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surprising interaction between "as_list" and "all" #962

Closed
mitar opened this issue Dec 7, 2019 · 3 comments
Closed

Surprising interaction between "as_list" and "all" #962

mitar opened this issue Dec 7, 2019 · 3 comments

Comments

@mitar
Copy link
Contributor

mitar commented Dec 7, 2019

From reading here I understood that I have to use all=True if I want to get all results, and then do as_list=False to get a generator to iterate over. But in fact this does not work well together. By specifying all=True it first starts fetching all results and generator does not call anything with results as pages are coming in.

I think all=True should just work with as_list=False. If I understand correctly, all=True is a noop in that case because as_list=False already implies it?

@max-wittig
Copy link
Member

Yes. Basically, if you supply as_list you won't need all=True.

@mitar
Copy link
Contributor Author

mitar commented Dec 7, 2019

Yes, but I think that if you supply as_list all should just be ignored.

@max-wittig
Copy link
Member

Good point

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants