New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check-github-workflows fails when run in pre-commit.ci #21
Comments
The So I have two questions for you:
And a workaround:
If you commit the schemastore schema to your repo, I believe it would be appropriate to put it in a directory with a copy of the schemastore license. If that workaround is satisfying for you, I could document it in the readme. |
Thanks for the fast response. Concerning your questions, I'm using |
I looked into the pre-commit.ci issue tracker a bit, and it seems that the system disallows use of the network at runtime. That's reasonable, but it also poses a problem for how I designed I think the best possible solution is for I also want to look into adding some retries for the download step and better logging if it fails and we don't have a failover schema to use, but that can be done later. |
Indeed it makes sense to disallows the use of network at runtime. The failover would be a very nice feature. |
I've just released version 0.8.0, which adds in builtin schemas, including vendorized copies of the ones for the default hooks, and a behavior to failover to these schemas when downloading fails. I believe this is sufficient to resolve this issue, so I've closed. But if someone could confirm that the fix works, that would be awesome! Please reopen if 0.8.0 isn't solving this. |
Hi, I have test with 0.8.2 and there is no crash |
Hello,
Thanks for this very nice hook.
I'm using your hook on the
.pre-commit-config.yaml
file :And the pre-commit action crash with this errors :
Am I doing something wrong (forgetting some parameters or so) ?
Thanks
The text was updated successfully, but these errors were encountered: