-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement $schema #55
Comments
I'm guessing you mean support in the plain What should happen if a |
Right, in
I think we should default to one. The next release will be 1.0.0 so we can now make that default be draft 4 I think. |
Uh. Whoops? |
I have something for this, just trying to get all the updates merged in to the draft 4 branch now and tests updated. Do you think we should just have extra keys in |
Okay, here's what I've got. I'm unsure if schema URIs should just be mixed in with the common names in the |
Ech yes. I don't know why I said we should get this done before merging, I didn't actually mean that 😦. Let's see here... |
Oh, sorry if I was premature there. I was just trying get the updated tests into draft 4 branch before working on it again. |
We can always go back and do the merge again if I've done it wrong. |
No no :)... It looks fine, I just didn't mean to say "we need this |
Oh no, I didn't take it that way. It just felt right to implement $schema in the draft 4 branch, and I wanted to pull in the master changes/tests before they diverged any further. |
Ah OK, good. So I'll take a look in a bit, looks more or less mergeable as is. |
Merged in #59. |
No description provided.
The text was updated successfully, but these errors were encountered: