Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #54 broke installer? #66

Closed
theyosh opened this issue May 27, 2020 · 6 comments
Closed

Pull request #54 broke installer? #66

theyosh opened this issue May 27, 2020 · 6 comments

Comments

@theyosh
Copy link

theyosh commented May 27, 2020

Hi,

how to install this software, now the setup.py file is deleted? How can I use this library in my software?

Example code at: https://github.com/python-kasa/python-kasa#discovering-devices-1 is not working.

Traceback (most recent call last):
  File "test.py", line 2, in <module>
    from kasa import Discover
  File "/tmp/TerrariumPI/python-kasa/kasa/__init__.py", line 15, in <module>
    from kasa.discover import Discover
  File "/tmp/TerrariumPI/python-kasa/kasa/discover.py", line 9, in <module>
    from kasa.smartbulb import SmartBulb
  File "/tmp/TerrariumPI/python-kasa/kasa/smartbulb.py", line 5, in <module>
    from kasa.smartdevice import (
  File "/tmp/TerrariumPI/python-kasa/kasa/smartdevice.py", line 17, in <module>
    from dataclasses import dataclass
ModuleNotFoundError: No module named 'dataclasses'

How to fix this?

@basnijholt
Copy link
Contributor

You need to use Python 3.7 or higher.

@theyosh
Copy link
Author

theyosh commented May 27, 2020

Stil does not work. There is no installer anymore. So how to install it. Do I need to install poetry in order to make it installable?

Running with Python 3.7.3:

Traceback (most recent call last):
  File "test.py", line 2, in <module>
    from kasa import Discover
  File "/home/pi/TerrariumPI/python-kasa/kasa/__init__.py", line 14, in <module>
    from importlib_metadata import version  # type: ignore
ModuleNotFoundError: No module named 'importlib_metadata'

That means I need to install https://pypi.org/project/importlib-metadata/ etc...

So please add an installation section in your documentation. How do I install this. Before the setup.py file was removed, it was quite easy. python3 setup.py install but that is not available anymore.

@basnijholt
Copy link
Contributor

@rytilahti, should we revert to a setup.py? It's causing quite a bit of confusion.

@theyosh
Copy link
Author

theyosh commented May 27, 2020

Or, add a small installation section in the readme file. I do not mind to do some installation, as long it is clear.

And I am not yet familiar with Poetry, but do know pip and other installers. So before I start doing all kind of installs and setups, it is handier to have some explanation how to build the package.

@basnijholt
Copy link
Contributor

There is some discussion about that in #60.

@theyosh
Copy link
Author

theyosh commented May 27, 2020

Hmm, I missed that. I think that is the same thing. So, then I suggest I close this one, and continue on the #60 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants