Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry for Traces #181

Open
Agalin opened this issue Oct 9, 2020 · 7 comments
Open

Support OpenTelemetry for Traces #181

Agalin opened this issue Oct 9, 2020 · 7 comments

Comments

@Agalin
Copy link
Contributor

Agalin commented Oct 9, 2020

Is your feature request related to a problem? Please describe.
Would be great if there was option to use OpenTelemetry instead of OpenTracing. It seems that it can quickly become the main tracing protocol considering that it's an official merger of OpenTracing and OpenCensus, a sandbox project of CNCF. Both Microsoft and Google are maintaining the opentelemetry-python repo, Lightstep is one of the founding contributors, Sentry has decided to completely drop experimental OpenTracing support and contributed an official exporter to OpenTelemetry instead and so on.

Describe the solution you'd like
There is an official Flask integration in OpenTelemetry Python SDK repo.

Describe alternatives you've considered
It's possible to stay with just OpenTracing but sooner or later it will be a limiting factor - migration is suggested by OpenTracing maintainers and big projects probably won't add new OpenTracing support anymore (see Sentry example) so it's a dead end.

@alexppg
Copy link
Member

alexppg commented Oct 11, 2020

We can use this issue to track the metrics and the traces or change the scope of this one to traces and create one for metrics.

In the middle-time, there's some work done for metrics, as seen above.

@Agalin
Copy link
Contributor Author

Agalin commented Oct 11, 2020

I've created this issue with specifically traces in mind so would rather see separate one for metrics (somehow didn't realize that OpenTelemetry supports metrics).

@alexppg
Copy link
Member

alexppg commented Oct 11, 2020

We might need to join the traces and the metrics services (and the logging in the future). The auto-instrumentation for the metrics seem to be on very early stages, but there's already some work done for the requests module. Still unreleased, but I've test it and it works nicely.
What this could mean is that, since the OT api will give one method to activate both metrics and traces, it might make sense to have it all in the same service. It will still be need to be handled differently by the configuration, but on the same service.

@alexppg
Copy link
Member

alexppg commented Oct 11, 2020

As said on the MR I would treat, for now, any integration with OT as a beta feature. So as @Agalin suggests, we could have both services at the same time.
So, we could create the telemetry service while maintaining both the metrics (with prometheus_client metrics) and traces service (with opentracing traces).
What do you thing @avara1986 ?

@avara1986
Copy link
Member

Great discussion @alexppg @Agalin , I didn't know OpenTelemetry. As you say, if OpenTelemetry is "the future", it will be better add a service to support that, but, as @alexppg say, if OpenTelemetry is still in beta, could be better support both options for a while

@Agalin
Copy link
Contributor Author

Agalin commented Oct 12, 2020

Seems like a good idea especially that it would merge a lot of services into one.

@alexppg alexppg changed the title Support OpenTelemetry Support OpenTelemetry for traces Oct 14, 2020
@alexppg alexppg changed the title Support OpenTelemetry for traces Support OpenTelemetry for Traces Oct 14, 2020
@alexppg
Copy link
Member

alexppg commented Oct 14, 2020

Nice, we'll then leave this issue for traces and I'll work on the one for metrics on the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants