add fixer for sorted() and list.sort
#200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixer shoud bu optional because |
In python3, `sorted()` and `list.sort()` only accept keyword-only argument and drop support of the `cmp` flag. This fixer helps you overcome all these trap by wrapping `functools.cmp_to_key` to original `cmp` argument and transforming it to `key` argument. See https://docs.python.org/3.8/library/stdtypes.html#list.sort
squirrel532
force-pushed
the
fix-sorted
branch
from
c46a83e
to
1488ca2
Compare
|
I'd say it's OK for it to it to be on by default, by analogy with the dict fixers that assume e.g Either way, it should have some tests. Tests for python-modernize are pretty simple: give some input code and the expected output. E.g. here for the map fixer |
squirrel532
force-pushed
the
fix-sorted
branch
from
68b9628
to
ec226aa
Compare
squirrel532
force-pushed
the
fix-sorted
branch
from
ec226aa
to
b086fa7
Compare
|
@takluyver Could you help me put some description and warning into document ? I'm not sure how to edit it correctly. |
|
@azdkj532 I think this fixer should be in fissix as it doesn't involve |
|
I'll file a PR to fissix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python3,
sorted()andlist.sort()only accept keyword-onlyargument and drop support of the
cmpflag. This fixer helps youovercome all these trap by wrapping
functools.cmp_to_keyto originalcmpargument and transforming it tokeyargument. Seehttps://docs.python.org/3.8/library/stdtypes.html#list.sort