Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurse references in validation #125

Merged
merged 1 commit into from May 12, 2021
Merged

Recurse references in validation #125

merged 1 commit into from May 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2021

JSON schema references can be nested in complex schemas.
Recurse in dereferencing logic until the returned item is no
longer a reference.

Also: Added a recursion to test data and fixed a typo
in test_shortcuts.py.

JSON schema references can be nested complex schemas.
Recurse in dereferencing logic until the returned item is no
longer a reference.

Also: Added a recursion to test data and fixed a typo
in test_shortcuts.py.
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #125 (b853de4) into master (2adca8a) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   98.26%   98.46%   +0.19%     
==========================================
  Files          19       19              
  Lines         518      520       +2     
==========================================
+ Hits          509      512       +3     
+ Misses          9        8       -1     
Impacted Files Coverage Δ
openapi_spec_validator/validators.py 99.07% <100.00%> (+<0.01%) ⬆️
openapi_spec_validator/decorators.py 97.56% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adca8a...b853de4. Read the comment docs.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p1c2u
Copy link
Collaborator

p1c2u commented May 12, 2021

@evahala thank you for the contribution.

@p1c2u p1c2u merged commit 327a4c1 into python-openapi:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant