Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for pre-commit #83

Merged
merged 1 commit into from Jan 13, 2020
Merged

Adds support for pre-commit #83

merged 1 commit into from Jan 13, 2020

Conversation

Grimlock257
Copy link
Contributor

Adds support for pre-commit.

Would need this commit to be tagged too if possible so pre-commit can pick it up!

@p1c2u
Copy link
Collaborator

p1c2u commented Oct 15, 2019

Hi @Grimlock257 . Thank you for the contribution. I'm not familiar with pre-commit. How can i test it and how to tag this commit?

@Grimlock257
Copy link
Contributor Author

Hi @Grimlock257 . Thank you for the contribution. I'm not familiar with pre-commit. How can i test it and how to tag this commit?

You'll need to install pre-commit: pip install pre-commit and then run pre-commit install.

You should then be able to do a pre-commit run on git staged changes to an openapi.yaml file. pre-commit will automatically run when a git commit is performed.

I'm not overly familiar with using git tags on a PR as I've never done it before; only to the master branch, for master branch it would be git tag 0.2.9 (or whatever version you want to give it) and then git push origin --tags. If you want I can add a tag to this branch with 0.2.9 as the release number (or a different version if you want) and I'm pretty sure when merged it adds it to the releases.

@p1c2u
Copy link
Collaborator

p1c2u commented Oct 15, 2019

Ah I see just version tag. I thought tere needs to some specific one. No worries I will add tag with new version release. Thanks.

@Grimlock257
Copy link
Contributor Author

Yeah, sorry - my bad for not being clear enough :)

@p1c2u p1c2u merged commit b512034 into python-openapi:master Jan 13, 2020
@Grimlock257
Copy link
Contributor Author

Hey, would you be able to do the version tag at some point, please! :)

@bowenwr
Copy link

bowenwr commented Jul 23, 2020

We could also really use this if it can make it into a version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants