Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to using requests rather than direct use of urllib3 #93

Merged
merged 3 commits into from Feb 18, 2021

Conversation

Beirdo
Copy link
Contributor

@Beirdo Beirdo commented Apr 19, 2020

  • Use a StringIO buffer as YAML is stupid and won't use a Byte Stream
  • included a version bump to keep PyPi happy should this be merged

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #93 (f1267ac) into master (76b4e2a) will decrease coverage by 0.30%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   98.69%   98.39%   -0.31%     
==========================================
  Files          14       18       +4     
  Lines         459      497      +38     
==========================================
+ Hits          453      489      +36     
- Misses          6        8       +2     
Impacted Files Coverage Δ
openapi_spec_validator/handlers/__init__.py 66.66% <66.66%> (ø)
openapi_spec_validator/handlers/base.py 100.00% <100.00%> (ø)
openapi_spec_validator/handlers/file.py 100.00% <100.00%> (ø)
openapi_spec_validator/handlers/requests.py 100.00% <100.00%> (ø)
openapi_spec_validator/handlers/urllib.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b4e2a...f1267ac. Read the comment docs.

@p1c2u
Copy link
Collaborator

p1c2u commented Aug 5, 2020

It's good idea to use request but it should be done as a separate Urlhandler rather than replacing the existing one

@p1c2u p1c2u merged commit d88b4b1 into python-openapi:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants