Improve requirements and environment markers parsing #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
requested changes
Jul 16, 2020
There was a problem hiding this comment.
vendor.txt needs to be updated. We should also drop 2.7 from the python version string from vendor/pyproject.toml so the lock file is cleaner.
Otherwise lark looks good. Should marker related code be in it's own package rather than under version?
Also, can we drop pyparsing.py from _vendor?
sdispater
force-pushed
the
improve-requirement-and-markers-parsing
branch
2 times, most recently
from
ee0af29
to
341fb3d
Compare
sdispater
force-pushed
the
improve-requirement-and-markers-parsing
branch
from
341fb3d
to
24ed1cd
Compare
|
I'll go ahead and merge this so that it can be tested in the next beta release of Poetry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the parser we use to parse requirements and environment markers.
We drop
pyparsingfor https://github.com/lark-parser/lark which gives a 3 to 4 times boost in performance. This is especially true for complex markers.