Fix: Exclude file from wheel when listed in gitignore and src layout is used #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before setting source root to the package base fix (masonry.builders.wheel): fix substitution in string formation new (tests.masonry.builders.test_wheel): test to check if file is excluded in wheel, when listed in gitignore and src layout is used
abn
requested changes
Sep 16, 2020
…dIncludeFile` to store the original path to the project's root folder new (masonry.builders.builder): method to return relative path to project's root for `BuildIncludeFile` change (masonry.builders.builder): use relative path to project's root when checking if BuildIncludeFile is excluded fix (masonry.builders.wheel): fix substitution in string formation
abn
reviewed
Sep 17, 2020
…ttribute of `Builder` fix (masonry.builders.builder): fix some type hints
abn
approved these changes
Sep 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a
src-layout is used, excluding files via.gitignorecurrently fails for build wheels.This is due to the fact that
vcs.get_ignored_files()gives the relative path to the project folder, but the current file is given relative to the package folder.This PR fixes this by make the comparison relative to the project folder.
Resolves: python-poetry/poetry#2910