Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C during interactive dependency selection breaks bash #2067

Closed
3 tasks done
gjoseph92 opened this issue Feb 20, 2020 · 2 comments
Closed
3 tasks done

Ctrl-C during interactive dependency selection breaks bash #2067

gjoseph92 opened this issue Feb 20, 2020 · 2 comments
Labels
area/cli Related to the command line kind/bug Something isn't working as expected

Comments

@gjoseph92
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: macOS High Sierra 10.13.6, bash 3.2 (system)
  • Poetry version: 1.0.3
  • Link of a Gist with the contents of your pyproject.toml file: N/A

Issue

Likely very related to #1593.

If I interrupt (ctrl-c) while interactively selecting dependencies, no characters are echoed in the shell, and prompts show up on the same line when hitting Return. Blindly typing reset (as mentioned here) fixes things.

gabejoseph ~/proj/poetry-test3 $ poetry init

This command will guide you through creating your pyproject.toml config.

Package name [poetry-test3]:  
Version [0.1.0]:  
Description []:  
Author [Gabe Joseph <gabe@descarteslabs.com>, n to skip]:  
License []:  
Compatible Python versions [^3.6]:  

Would you like to define your main dependencies interactively? (yes/no) [yes] 
You can specify a package in the following forms:
  - A single name (requests)
  - A name and a constraint (requests ^2.23.0)
  - A git url (git+https://github.com/python-poetry/poetry.git)
  - A git url with a revision (git+https://github.com/python-poetry/poetry.git#develop)
  - A file path (../my-package/my-package.whl)
  - A directory (../my-package/)
  - An url (https://example.com/packages/my-package-0.1.0.tar.gz)

Search for package to add (or leave blank to continue): foobar
Found 20 packages matching foobar

Enter package # to add, or the complete package name if it is not listed: 
 [0] foobar
 [1] foobar2
 [2] duckietown-foobar
 [3] django-foobar
 [4] ModernGL.ext.foobar
 [5] pytest-check-mk
 [6] qoob
 [7] pyfoobar
 [8] sower
 [9] pyctrie
# I hit Ctrl-C here. Poetry exits, but the shell is then in a 'broken state'
 > gabejoseph ~/proj/poetry-test3 $ gabejoseph ~/proj/poetry-test3 $ gabejoseph ~/proj/poetry-test3 $ 
# ^ hitting return puts a new prompt on the same line. no characters are echoed when typing.
@gjoseph92 gjoseph92 added the kind/bug Something isn't working as expected label Feb 20, 2020
@finswimmer finswimmer added the area/cli Related to the command line label Feb 21, 2020
@finswimmer
Copy link
Member

Fixed on cleo's side python-poetry/cleo#240

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants