Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding individual files to the source distribution #2087

Closed
Cito opened this issue Feb 26, 2020 · 2 comments
Closed

Allow adding individual files to the source distribution #2087

Cito opened this issue Feb 26, 2020 · 2 comments
Labels
kind/feature Feature requests/implementations
Milestone

Comments

@Cito
Copy link

Cito commented Feb 26, 2020

When using setuptools for building source distributions, it is possible to specify extra stuff that should only go into the source distribution, but not into the wheels (like the LICENSE file or unit tests) in the MANIFEST.in file.

The question that was already asked in #1067 - how can we specify such extra files when building sdists with poetry? The proposed and implemented solution was to use the format = "sdist" specification in the packages setting. This works and solves the problem - but only for packages. So I'm re-raising the same question for other extra files that are not packages, for example configuration files like .flake8 or text files with additional information like INSTALLATION.md or AUTHORS.md. As far as I see, only the main README.md and LICENSE files specified in pyproject.toml are included when poetry builds an sdist.

You can specify such files using the include setting, but then they would also appear in the wheels.

So I think poetry is missing something like format = "sdist" for the include and exclude settings, or it should use an existing MANIFEST.in. Alternatively, poetry could automatically include everything that is under version control and not excluded into the source distribution. Or am I missing or misunderstanding something here?

@Cito Cito added the kind/feature Feature requests/implementations label Feb 26, 2020
@sdispater sdispater added this to the 1.1 milestone Feb 28, 2020
@kasteph
Copy link
Member

kasteph commented Apr 26, 2020

Resolved by #6 and will be available in 1.1.0.

@kasteph kasteph closed this as completed Apr 26, 2020
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

3 participants