Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry incorrectly resolves tensorflow-estimator #2205

Closed
3 tasks done
alkamid opened this issue Mar 20, 2020 · 6 comments
Closed
3 tasks done

Poetry incorrectly resolves tensorflow-estimator #2205

alkamid opened this issue Mar 20, 2020 · 6 comments
Labels
area/solver Related to the dependency resolver kind/bug Something isn't working as expected

Comments

@alkamid
Copy link

alkamid commented Mar 20, 2020

Issue

tensorflow==2.1.0 depends on tensorflow-estimator. This is the relevant output from poetry lock -vvv:

   1: fact: tensorflow (2.1.0) depends on tensorflow-estimator (>=2.1.0rc0,<2.2.0)   
   1: derived: tensorflow-estimator (>=2.1.0rc0,<2.2.0)
PyPI: 3 packages found for tensorflow-estimator >=2.1.0rc0,<2.2.0 
   1: selecting tensorflow-estimator (2.2.0rc0)  

tensorflow-estimator==2.1.0 is available on PyPI (https://pypi.org/project/tensorflow-estimator/#history), so I'd expect poetry to select 2.1.0 rather than 2.2.0rc0. Is this expected behaviour?

See tensorflow/tensorflow#37525 for the issue it's causing.

@alkamid alkamid added the kind/bug Something isn't working as expected label Mar 20, 2020
@finswimmer finswimmer added the area/solver Related to the dependency resolver label Mar 20, 2020
@ClementWalter
Copy link

Same issue here. I would not expect that poetry select any release candidate package by default. Thanks

@charmasaur
Copy link

FYI I think the underlying issue here is #2271

@ClementWalter
Copy link

This issue as a real impact on tensorflowjs as poetry add tensorflowjs will resolve with tensorflow-estimator==2.2.0rc0 which in turns make tf js unusable.

MWE:

pyenv virtualenv 3.6.9 test_tfjs
pyenv activate test_tfjs
poetry add tensorflowjs
python -c "import tensorflowjs"

@dimbleby
Copy link
Contributor

Works as expected today

(after tweaking the provided pyproject.toml to specify tensorflow = "=2.1.0", then indeed poetry derives tensorflow-estimator (>=2.1.0rc0,<2.2.0), but now it installs 2.1.0 as desired)

@mkniewallner
Copy link
Member

Closing, since this appears to be fixed now.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

6 participants