False-positive checks for Miniconda base environment (prevents shadowing by other virtual environments) #2562
Labels
area/venv
Related to virtualenv management
kind/bug
Something isn't working as expected
status/triage
This issue needs to be triaged
-vvv
option).4.4.0-184-generic #214-Ubuntu SMP Thu Jun 4 10:14:11 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
)Issue
When the Miniconda "base" environment is active then Poetry won't allow shadowing by other environments, e.g. such as created by Nox. In my specific case, I ran a shell with Miniconda "base" active, then I ran tests through Nox where dependencies are installed via Poetry (see this for example; invoke via
nox -s tests
). Even though the Nox environment was active, Poetry refused to use it because it thought it is inside the Miniconda "base" environment (and hence Poetry created its own environment to install dependencies into). This comes from the following check:Here
in_venv
is False no matter if theVIRTUAL_ENV
variable is set, in case the Miniconda "base" environment is active too. Instead it should explicitly distinguish betweenVIRTUAL_ENV
set or not when checking theCONDA_DEFAULT_ENV
:The text was updated successfully, but these errors were encountered: