-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poetry 1.3.0 and pillow issues on linux ubuntu 20.04 x86_64 #7177
Comments
There are two issues here; the first is you cannot have your project named the same as a dependency. This is because Python packages (and also importable modules, though it is a M:N relationship) have a flat namespace. Clearly we could better detect and warn about this error instead of throwing an AssertionError (cc @radoering @dimbleby), but there is no bug, just poor messaging. I'd appreciate opening a new issue narrowly targeting the case of package name collisions with a dependency. The second issue is a duplicate of #7161 and caused because pip and Poetry now disagree on wheel tags and pip is used by Poetry, but the pip version is uncontrolled as we're using the version present in your target virtual environment. See that issue for details; but in general this kind of issue is rare but can happen until we finish the work in #6205. |
Many thanks for your quick reply. |
I think this actually isn't #7161: or rather it's a demonstration that the same issue has existed, in principle, for some time now. packaging 21.3 on my 20.4 ubuntu system includes the tag "cp38-cp38-manylinux_2_28_x86_64". So most likely this particular example could be solved by the user updating their pip installation. |
Thanks @dimbleby, indeed by doing: poetry new pillow0
cd pillow0
python3 -m venv venv
source venv/bin/activate
pip install pip -U
poetry add pillow
Using version ^9.3.0 for pillow
Updating dependencies
Resolving dependencies... (0.2s)
Writing lock file
Package operations: 1 install, 0 updates, 0 removals
• Installing pillow (9.3.0) It worked as expected. |
Looks like #7161 in aggregate, but not in specifics, indeed. I think what distinguishes that issue is that it relates to |
Or add in |
Without maintaining a table of pip versions, that is not a very tractable solution, and the table of versions is very manual and prone to inaccuracies. I don't think that is a useful approach to take. |
I'm just wondering how then |
Oh, you're suggesting unconditionally instructing the user to upgrade pip. pip pings a remote server and it's an implementation detail, but I don't think we can depend on their infrastructure in a maintainable way. In any case, we're on the cusp of dropping pip, so I think this is mostly immaterial. |
Many thanks for the clarification. I got a much better understanding. |
pip 22+ resolves the issue. |
Yes, I can confirm that this is now working fine for me too, with |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option) and have included the output below.Issues
Why I cannot have a project with 'pillow' name?
Moving on the real issue.
But I have no problem if doing:
Do you notice that
poetry
tries to installPillow-9.3.0-cp38-cp38-manylinux_2_28_x86_64.whl
while pip installs, successfully,Pillow-9.3.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
.What is
poetry
trying to do here?The text was updated successfully, but these errors were encountered: